Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request type detection #14

Open
y-lohse opened this issue Mar 15, 2016 · 1 comment
Open

Request type detection #14

y-lohse opened this issue Mar 15, 2016 · 1 comment

Comments

@y-lohse
Copy link

y-lohse commented Mar 15, 2016

Hi,
i encountered a small problem, not sure if it could be considered a bug.

I'm doing my upload with a POST request — as in, the HTTP header is set to post and the resumable data is in the POST body.
However, the URL I'm sending the POST request to has a GET param as well, ie. ``htttp://localhost/upload?token=lol`. Because of that, the SimpleRequest class in Resumable.php thinks it's a GET request, tried to load the params from GET and fails.

I think it would make sense to change the code here to use the HTTP header to detect the type of request rather than the ìsset() call. What do you think? I can probably submit a PR if that's ok for you.

@dilab
Copy link
Owner

dilab commented Mar 22, 2016

I think your point is valid.

a PR is always welcomed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants