Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pass parameter when confirm the execution? #26

Closed
phoenixg opened this issue Apr 15, 2019 · 13 comments
Closed

How to pass parameter when confirm the execution? #26

phoenixg opened this issue Apr 15, 2019 · 13 comments

Comments

@phoenixg
Copy link

For example, I want to pass the date.

@dillingham
Copy link
Owner

Do it in your listener

@phoenixg
Copy link
Author

@dillingham Listener can catch the event's parameter, but it cannot change it to other value.

@dillingham
Copy link
Owner

It’s the model, update it. Good luck 👍

@phoenixg
Copy link
Author

Hmmmmm, but I actually want an input box to manually change it on the web interface.

@SerjoA
Copy link

SerjoA commented Apr 16, 2019

its not possible at the moment

@phoenixg
Copy link
Author

@SerjoA Is it possible in the future?

@SerjoA
Copy link

SerjoA commented Apr 17, 2019

iam not one of the mainteners
i am working on it also for my self but for the moment i dont know how much time it will take

@SerjoA
Copy link

SerjoA commented Apr 17, 2019

i thought about an api like this:
Button::make('Deposit')
->action(DepositAction::class)
->canSee(.....),

i think it will be better than say:
Button::make('Deposit')
->fields([
Text::make('Amount'),
])
->canSee(.....),

in terms of reusability and etc
if and when ill finish ill submit pr

@dillingham
Copy link
Owner

I don’t want to add resolving fields to this package. I did it in another package of mine and it’s been a headache. I would merge in ->action() if it somehow relied on novas native handling of all that stuff. Ui / controller etc.

@SerjoA
Copy link

SerjoA commented Apr 17, 2019

ok, if i succeed with that i will submit pr
thanks for the package

@dillingham
Copy link
Owner

@phoenixg I didn’t understand your question originally. Here is a related thread #18

@dillingham
Copy link
Owner

@SerjoA awesome, feel free to ask questions of brainstorm on that thread and I’ll try to help as much as I can

@phoenixg
Copy link
Author

@SerjoA Looking forward to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants