Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only last added button is working on latest nova version (v2.4.0) #50

Open
funkdoobiest opened this issue Oct 15, 2019 · 13 comments · May be fixed by #81
Open

Only last added button is working on latest nova version (v2.4.0) #50

funkdoobiest opened this issue Oct 15, 2019 · 13 comments · May be fixed by #81

Comments

@funkdoobiest
Copy link

funkdoobiest commented Oct 15, 2019

When I add more than one button, only the last added button will work. Clicking on other buttons have no effect. There is no error in console nor an xhr request will be fired.

@dillingham
Copy link
Owner

Can you provide some code to examine

@funkdoobiest
Copy link
Author

funkdoobiest commented Oct 16, 2019

Sure.

           Button::make('Approve', 'inquiry-approve')
                ->style('primary-outline')
                ->confirm('Are you sure?')
                ->visible($this->status == 'pending'),

            Button::make('Decline', 'inquiry-decline')
                ->style('danger-outline')
                ->confirm('Are you sure?')
                ->visible($this->status == 'pending'),

"Approve" button is not working, "Decline" is. If I remove "Decline", "Approve" works.
This code worked before update to L6 und latest Nova version.

@funkdoobiest
Copy link
Author

More details: if I remove the "confirm", both buttons are working.
Seems like if two buttons with confirmation are on same page, only last is opening the modal.

@rsiasat00
Copy link

Confirming that this issue exists on Laravel Nova v2.5.

Only the last button of the last row can be clicked when using confirm().

@PaulLawton227
Copy link

Confirming that this issue exists on Nova 2.6.1

Button::make('Quick Pay')->confirm('Are you sure?', view('partials.quickpay')->render())

the confirm dialog does not show, except for the last row in the index list.

@dillingham
Copy link
Owner

People are welcome to contribute a solution. I'll review

@funkdoobiest
Copy link
Author

Tried to find a solution, but my Vue-skills are not good enough ;-)

@noxahti
Copy link

noxahti commented Dec 7, 2019

I updated to v2.8.0 today. Same thing is still happening.

@vayurobins
Copy link

I have same issue in 2.8.0

@nilsE
Copy link

nilsE commented Jan 6, 2020

and still the same issue in 2.9.2 - could you please fix this?

@noxahti
Copy link

noxahti commented Mar 7, 2020

Any updates on this? I tried to find a solution but couldnt. My js skills are not good as well :(

marijnhurkens added a commit to qikker-online/nova-button that referenced this issue Mar 30, 2020
@marijnhurkens
Copy link

@dillingham Please review the pull request, thanks :)

@skoyah
Copy link

skoyah commented May 4, 2020

What's the current state of this issue? It seems I have the same problem on an app I'm building.

@fh32000 fh32000 linked a pull request Mar 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants