Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2] ThreatenGL incompatibility. #86

Open
1 task done
JelowPapua opened this issue Aug 1, 2024 · 1 comment
Open
1 task done

[1.19.2] ThreatenGL incompatibility. #86

JelowPapua opened this issue Aug 1, 2024 · 1 comment
Labels
crash If the game crashes

Comments

@JelowPapua
Copy link

Make sure you are not opening a duplicate.

Minecraft version.

1.19.2

Rubidium/Embeddium Extra version.

0.4.19

Rubidium/Embeddium version.

0.3.18.1

What happened?

Embeddium Extra and ThreatenGL try to modify the same mixin:
[Render thread/WARN] [mixin/]: @Redirect conflict. Skipping sodium-extra.mixins.json:reduce_resolution_on_mac.MixinWindow->@Redirect::onDefaultWindowHints(II)V with priority 1000, already redirected by threatengl.mixins.json:ThreatenGLMixin->@Redirect::hintOverride(II)V with priority 1000

I tried replicating the issue on Fabric 1.19.2 and installing Sodium, Sodium Extra and ThreatenGL and it ran perfectly, no Sodium Extra incompatibility, then I tried doing a clean installation of Forge 1.19.2 with Embeddium, Embeddium (Rubidium) Extra and ThreatenGL and the crash persisted so the problem seems to be the Forge port of Embeddium Extra, I tried looking into that mixin of the Forge port and from line 31 to 38 it's a bit different:

Fabric
https://github.com/FlashyReese/sodium-extra-fabric/blob/1.19.x/dev/src/main/java/me/flashyreese/mods/sodiumextra/mixin/reduce_resolution_on_mac/MixinWindow.java#L31-L38

Forge
https://github.com/dima-dencep/rubidium-extra/blob/1.19.x/stable/src/main/java/me/flashyreese/mods/sodiumextra/mixin/reduce_resolution_on_mac/MixinWindow.java#L31-L38

I don't know if this is even useful but it might just help.

Relevant logs

https://pastebin.com/eGBpEnsb

Additional information

No response

@JelowPapua JelowPapua added the crash If the game crashes label Aug 1, 2024
@JelowPapua
Copy link
Author

I got the mods working together by downloading the files for 1.19.x and building a version without the "reduce resolution on mac" mixin and any mention of it within the mod's files, this don't break anything on my end since I use windows. Anyway, the problem seems to lie in that mixin if it's of any help.

Weirdly enough, they don't conflict each other on their Fabric counterparts as I mentioned before in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash If the game crashes
Projects
None yet
Development

No branches or pull requests

1 participant