Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColliderDebugColor should contain a Color #572

Open
rparrett opened this issue Jul 25, 2024 · 0 comments
Open

ColliderDebugColor should contain a Color #572

rparrett opened this issue Jul 25, 2024 · 0 comments

Comments

@rparrett
Copy link
Contributor

rparrett commented Jul 25, 2024

ColliderDebugColor now contains an Hsla, which means the user's colors now need to undergo conversion from

(User's color space if not Hsla) ->
Hsla->
Color (no color space conversion here) ->
(deep in Bevy's gizmo renderer, LinearRgba)

bevy_rapier also seems to convert from Hsla to [f32, 4] and back to Hsla for no discernible reason in object_color and e.g. draw_line.

Given that the ultimate destination of these colors is Gizmos, and Gizmos want Color, I think we should just use Color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant