Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serde derives for KinematicCharacterController #506

Closed
PaulL48 opened this issue Jul 26, 2023 · 2 comments
Closed

Add serde derives for KinematicCharacterController #506

PaulL48 opened this issue Jul 26, 2023 · 2 comments

Comments

@PaulL48
Copy link
Contributor

PaulL48 commented Jul 26, 2023

KinematicCharacterController appears to be a good candidate to be Serialize/Deserialize. This would require adding serde derives for the following structs.

  • CharacterLength
  • CharacterAutostep
  • KinematicCharacterController
@PaulL48
Copy link
Contributor Author

PaulL48 commented Jul 26, 2023

I've got the changes tested and ready for a PR. I rarely contribute to OS projects so I just wanted to follow the guideline and create an issue to be assured that everything is OK before creating the PR.

@PaulL48 PaulL48 mentioned this issue Aug 2, 2023
Merged
@sebcrozet
Copy link
Member

The corresponding PR #508 was merged a while ago. We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebcrozet @PaulL48