Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the fixing of un-optimized M4A #97

Open
skyline75489 opened this issue Oct 21, 2024 · 3 comments
Open

Improve the fixing of un-optimized M4A #97

skyline75489 opened this issue Oct 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@skyline75489
Copy link

For some songs, the current implementation does not fetch enough data for mdat to show up. This is one of the problematic songs:

Atom ftyp @ 0 of size: 32, ends @ 32
Atom free @ 32 of size: 112547, ends @ 112579
Atom free @ 112579 of size: 483674, ends @ 596253
Atom mdat @ 596253 of size: 6359629, ends @ 6955882
Atom moov @ 6955882 of size: 113172, ends @ 7069054
     Atom mvhd @ 6955890 of size: 108, ends @ 6955998
     Atom trak @ 6955998 of size: 69281, ends @ 7025279

The mdat was at 596253. However the first packet received is only 13667 bytes long. The current logic does not takes this scenario into consideration.

@dimitris-c dimitris-c added the bug Something isn't working label Nov 3, 2024
@dimitris-c
Copy link
Owner

Hey, thanks for raising this issue, I'll try and provide a fix for this

@dimitris-c
Copy link
Owner

Could you add a file that's failing to test? thanks

@skyline75489
Copy link
Author

I'm not sure if I should share copyrighted music here. Let me see if I can find something public domain & with smaller size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants