Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming causes deletion of note #20

Open
codewilling opened this issue Aug 23, 2021 · 1 comment
Open

Renaming causes deletion of note #20

codewilling opened this issue Aug 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@codewilling
Copy link

codewilling commented Aug 23, 2021

Step 0) Select a note that you don't mind gets deleted. If you don't have a note that can be deleted, create a note. When you create a note, notice how the title does not need to be entered with the .md file extension.
Step 1) Click on the 'Rename Note' icon (next to the trash icon)
Step 2) Modify the title in the input popup (without the .md file extension, same UX as when you initially created the note)
Step 3) Press enter to submit
RESULT: The note gets deleted, while a popup at the bottom of vscode says '{note} renamed {newNote}'

Solution 1:
remove the popup at the bottom that says '{note} renamed {newNote}' & let user know saving without .md will delete note

Solution 2:
change UX to be same as when creating title. If only .md is allowed, than automatically add the extension to titles, whenever creating or updating title.

@dionmunk dionmunk added the bug Something isn't working label Aug 31, 2021
@dionmunk
Copy link
Owner

The problem is that if the note doesn't have a specific file extension, it will appear deleted and not appear in your notes list. Even though the actual file still exists, it is a file with no extension and is thus ignored by Notes. I think I'll update the extension to persist the original file extension when renaming a note. Thank you for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants