Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HBRI IPv4/IPv6 ADC extension #78

Open
maksis opened this issue Mar 18, 2019 · 7 comments
Open

Support HBRI IPv4/IPv6 ADC extension #78

maksis opened this issue Mar 18, 2019 · 7 comments
Labels
enhancement New feature or request
Milestone
Hub

Comments

@maksis
Copy link

maksis commented Mar 18, 2019

https://forum.dcbase.org/viewtopic.php?t=771
@dennwc dennwc added this to the Hub milestone Mar 18, 2019
@dennwc dennwc added the enhancement New feature or request label Mar 18, 2019
@dennwc
Copy link
Collaborator

dennwc commented Mar 18, 2019

The extension sounds reasonable and it makes sense to support it.

@maksis Can you please verify that IPv6-to-IPv6 client-client connection works currently with the hub?

@maksis
Copy link
Author

maksis commented Mar 18, 2019

I'll test that in a while... seems like the hub can't resolve "any" IP (::) sent to the hub to a correct address, which requires extra work with the client config

@dennwc
Copy link
Collaborator

dennwc commented Mar 18, 2019 •
edited
Loading

Hmm, right, one bug found: it only checks for "any" address for IPv4.

Opened an issue: #79

@maksis
Copy link
Author

maksis commented Mar 18, 2019

Seems like the CTM command isn't being received by the other user...

@dennwc
Copy link
Collaborator

dennwc commented Mar 18, 2019

OK, thanks, will investigate.

dennwc added a commit that referenced this issue Mar 18, 2019
@dennwc
hub: handle ip6 correctly; addresses #78
84df969
@dennwc
Copy link
Collaborator

dennwc commented Mar 18, 2019

@maksis Please check with the last commit (84df969). It should fix both issues.

@maksis
Copy link
Author

maksis commented Mar 19, 2019

Handling any address seems to work when connecting to the hub (but not when the IP is being changed to :: while already connected to the hub). CTM commands are still not being forwarded though. Did you test that it's working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Hub
Development

No branches or pull requests
2 participants
@dennwc @maksis