-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create guide for seeking audio resource #1483
base: main
Are you sure you want to change the base?
Conversation
Create guide for seeking audio resource.
ESLint is kinda... |
I'm afraid but could you run ESLint one more time? I have fixed all of the error and warning. |
Thanks bro |
Co-authored-by: megatank58 <[email protected]>
Co-authored-by: megatank58 <[email protected]>
k it seems like I've fixed all reviews you sent |
so I have to wait until ESLint approval and merge |
Hey I'm really sorry but could you run ESLint one more time |
Sorry could you re-run ESLint check (Why ESLint says readability is unnecessary) |
Thank you so much for running so many ESLint check |
Personally I'd be against having this as its own article. A more general |
@ducktrshessami Yeah, that's true enough, but honestly, this will eventually fit in voice section. Because adding content like this in popular topics does not related to discord.js directly. Adding this in voice section (because u know how do you use these things in other part of discord.js bot developing) will be better in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't referring to the "Popular Topics" section of the main guide. I agree that a guide about prism-media
is more relevant in the Voice guide. I am simply opposed to this as a standalone article. A new "Popular Topics" section can be added since this isn't directly related to @discordjs/voice
. If you do agree I'd definitely like to see this rewritten before being merged.
I see I got it. So you mean, like creating new 'Popular Topics' in voice MD and referring this kind of articles in it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see I got it. So you mean, like creating new 'Popular Topics' in voice MD and referring this kind of articles in it?
Yes
Create a guide for seeking audio resources.
Please describe the changes this PR makes and why it should be merged:
Explain how to seek audio resources with raw discord.js and @discordjs/voice
Many questions about seeking are posted on discord.js guild, and there's no guide about seeking. So I created this.