Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes at the crypto level #121

Open
Christewart opened this issue Dec 9, 2020 · 0 comments
Open

Breaking changes at the crypto level #121

Christewart opened this issue Dec 9, 2020 · 0 comments
Labels
adaptor-sigs question Further information is requested

Comments

@Christewart
Copy link
Contributor

As discussed at #119 @jesseposner is working diligently on getting ECDSA adaptor signatures merged into the secp256k1-zkp.

This presents a problem though: What do we do with DLCs that are using our current temp branch. This is a backwards breaking change to DLCs that are currently in flight.

This problem will occur again when we incorporate Schnorr as far as I know.

I'm definitely in favor of these break changes being obvious for users rather it being hard to detect. We can use TLV types but I know @nkohen has expressed concern about burning TLV types for minor things like this, but i'm unsure what else can be done.

@Christewart Christewart added question Further information is requested adaptor-sigs labels Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adaptor-sigs question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant