Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bech32 for displaying the nonce #95

Open
NicolasDorier opened this issue Sep 24, 2020 · 1 comment
Open

Bech32 for displaying the nonce #95

NicolasDorier opened this issue Sep 24, 2020 · 1 comment

Comments

@NicolasDorier
Copy link

Right now, we are showing the nonce as an hex string.
I think this should be changed as fast as possible.

The reason is, when taproot activate, we will want to move from ECDSA Adaptor sigs to Schnorr Adaptor sigs, by doing so, the attestations of the oracle will be different, so an oracle need a way to signal to users what they will be attesting.

Using Bech32, allows us to include this information in the hrp or inside the data, and on top of that make it encoding the nonce shorter.

@benthecarman
Copy link
Contributor

The reason is, when taproot activate, we will want to move from ECDSA Adaptor sigs to Schnorr Adaptor sigs, by doing so, the attestations of the oracle will be different

What the oracle signs shouldn't be different for if the users are using ECDSA or Schnorr, it should be able to be independent of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants