Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Makefiles and add GitHub Actions CI (replacing AppVeyor) #465

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Merge Makefiles and add GitHub Actions CI (replacing AppVeyor) #465

merged 5 commits into from
Dec 21, 2023

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Dec 17, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + tools#465"

@kinke kinke force-pushed the makefiles branch 4 times, most recently from 6fffba5 to 11b6751 Compare December 17, 2023 04:30
@kinke kinke mentioned this pull request Dec 17, 2023
Merged
@kinke kinke force-pushed the makefiles branch 10 times, most recently from 3d0d392 to 5cd476a Compare December 17, 2023 21:21
@kinke kinke force-pushed the makefiles branch 2 times, most recently from 296e623 to ae7f269 Compare December 17, 2023 21:38
@kinke kinke changed the title Merge Makefiles Merge Makefiles and add GitHub Actions CI (replacing AppVeyor) Dec 17, 2023
@kinke kinke marked this pull request as ready for review December 17, 2023 21:45
kinke
kinke commented Dec 17, 2023
View reviewed changes
rdmd_test.d
@@ -684,11 +684,11 @@ void runFallbackTest(string rdmdApp, string buildCompiler, string model)
if an explicit --compiler flag is not provided, rdmd should
search its own binary path first when looking for the default
compiler (determined by the compiler used to build it) */
string localDMD = buildPath(tempDir(), baseName(buildCompiler).setExtension(binExt));
string localDMD = buildPath(dirName(rdmdApp), baseName(buildCompiler).setExtension(binExt));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change, just clarifies things IMO (no need to know that rdmdApp lies in the tempDir() directory).

@kinke kinke merged commit 6670ee4 into master Dec 21, 2023
14 of 16 checks passed
@kinke kinke deleted the makefiles branch December 21, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@ibuclaw ibuclaw ibuclaw approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@CyberShadow CyberShadow Awaiting requested review from CyberShadow CyberShadow is a code owner

@wilzbach wilzbach Awaiting requested review from wilzbach wilzbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinke @dlang-bot @ibuclaw @thewilsonator