Composite functions have two differents implementation styles. Why?

[Gounlaf]

👋

This one use TemporaryDefines, relying on the the using keywork / disposable of TemporaryDefines to remove the artifact.

Magick.NET/src/Magick.NET/MagickImage.cs

Lines 2044 to 2052 in c022bb0

	public void Composite(IMagickImage image, int x, int y, CompositeOperator compose, string? args, Channels channels)
	{
	Throw.IfNull(nameof(image), image);
	using var temporaryDefines = new TemporaryDefines(this);
	temporaryDefines.SetArtifact("compose:args", args);
	_nativeInstance.Composite(image, x, y, compose, channels);
	}

This one doesn't

Magick.NET/src/Magick.NET/MagickImage.cs

Lines 2189 to 2205 in c022bb0

	public void Composite(IMagickImage image, Gravity gravity, int x, int y, CompositeOperator compose, string? args, Channels channels)
	{
	Throw.IfNull(nameof(image), image);
	if (args is not null)
	_nativeInstance.SetArtifact("compose:args", args);
	try
	{
	_nativeInstance.CompositeGravity(image, gravity, x, y, compose, channels);
	}
	finally
	{
	if (args is not null)
	_nativeInstance.RemoveArtifact("compose:args");
	}
	}

The only particular reason I see is that CompositeGravity would allow en empty (but not null) args string, and all other methods using the TemporaryDefines would not?

Magick.NET/src/Magick.NET/Helpers/TemporaryDefines.cs

Lines 28 to 35 in c022bb0

	public void SetArtifact(string name, string? value)
	{
	if (value is null || value.Length < 1)
	return;
	_names.Add(name);
	_image.SetArtifact(name, value);
	}

Thanks for the clarifications.

Regards.

[dlemstra]

That is code that has not yet been changed to use TemporaryDefines instead. I just pushed a patch to fix this. And as always thanks for reporting all these things.

[Gounlaf]

My pleasure 🙂