-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the colorbar and some bug fixes #43
Open
joshcalcino
wants to merge
17
commits into
dmentipl:main
Choose a base branch
from
joshcalcino:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks very much for the contribution @joshcalcino. Sorry for my slow response. I'll take a detailed look this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added more control over the way the colorbar is made. The previous version would try and combine the colorbar and plot within the ax object. I added an argument that allows the user to divide the colorbar and plot axes. This is useful when the user is trying to create a multi-panel plot and only want one colorbar on the plot (so each imshow ax has the same dimensions).
Added some bug fixes when importing phantom ev files.
Removed vmin and vmax kwargs before they're sent to plt.imshow and added them to norm function instead. This prevents a ValueError from occuring in the newest version of matplotlib.