Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debatable / incorrect test case CL3 / 0088-no-decision-logic #387

Open
opatrascoiu opened this issue Dec 23, 2020 · 5 comments
Open

Debatable / incorrect test case CL3 / 0088-no-decision-logic #387

opatrascoiu opened this issue Dec 23, 2020 · 5 comments

Comments

@opatrascoiu
Copy link
Contributor

I believe the above test case is not CL3 compliant. Here is the rationale:

  • According to 2.1 (page 17) "An implementation claiming conformance to Conformance Level 3 SHALL comply with all of the specifications set forth in clauses 6 (Decision Requirements), 7 (Decision Logic), 8 (Decision Table) and 10 (Expression language) of this document."
  • According to 7.1 (page 71) "The decision logic level of a decision model in DMN consists of one or more value expressions." This is a semantic constraint on the DMN metamodel which provides only syntactic constraints.

We should move it into the non-compliant section of the test cases.

@opatrascoiu opatrascoiu changed the title Debatable / incorrect test case cl3 / 0088-no-decision-logic Debatable / incorrect test case CL3 / 0088-no-decision-logic Dec 23, 2020
@StrayAlien
Copy link
Contributor

Hi @opatrascoiu, section 7.1 also has the following (which we have agreed somewhere else is incorrect - if I recall):

  • If a decision element requires more than one business knowledge element, its value expression must be a literal expression that specifies how the business knowledge model elements are invoked and how their results are combined into the decision's outcome.
  • If a decision does not require any business knowledge models, its value expression must be a literal expression or decision table that specifies the entire decision logic for deriving the output from the inputs.

If all tests that did not satisfy these two were moved into non-compliant that would sure be a lot of them! I'm not saying the test you mention should not be moved, more saying that section 7.1 is fairly misleading. Which is a pretty bad thing in such a spec ....

@StrayAlien
Copy link
Contributor

Btw @opatrascoiu - I raised https://issues.omg.org/issues/DMN14-139 to see if those silly sections of spec can be removed. But, I'll like to discuss this issue at monthly meeting if we can.

@baldimir
Copy link
Collaborator

Approved in DMN 1.5.

@baldimir
Copy link
Collaborator

baldimir commented Jun 15, 2023

Let's find out if the test is valid, and in which conformance level it should be, and we can resolve this on the next meeting.

@opatrascoiu
Copy link
Contributor Author

The issue raised https://issues.omg.org/issues/DMN14-139 was addressed in DMN 1.5. The changes did not alter the text mentioned in the first comment. Hence, I believe the statements in the description of the issue are still valid:

According to 2.1 (page 17) "An implementation claiming conformance to Conformance Level 3 SHALL comply with all of the specifications set forth in clauses 6 (Decision Requirements), 7 (Decision Logic), 8 (Decision Table) and 10 (Expression language) of this document."

According to 7.1 (page 71) "The decision logic level of a decision model in DMN consists of one or more value expressions." 

I believe that this is a semantic constraint.

Let's discuss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants