-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating saved annotations by searching annotations #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
A change that isn't substantial enough to be called a feature
label
Sep 13, 2023
jorg-vr
changed the title
Create index page for annotations
Allow creating saved annotations by searching annotations
Sep 19, 2023
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
September 19, 2023 08:52
bmesuere
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the outlined button in the table instead of a primary
niknetniko
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As mentioned IRL, the button to save a comment doesn't seem to be translated sometimes.
(and we'll ignore the 403 as the beta will go away soon)
app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts
Outdated
Show resolved
Hide resolved
niknetniko
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to remove the need for anticipation of reuse when saving annotations. A saved annotation can easily be created by searching the list of existing annotations.
Clicking the link under the saved annotations searchfield:
Brings the user the the prefiltered saved annotations list page
This page now has a
+
button to create new saved annotations. This + button links to the prefiltered list of annotations:These can of course be filtered or sorted as desired.
Here a user can easily save the annotation (I reused the existing modal for this)
The saved annotation detail page now also uses this list view of annotations instead of a list of submission:
This pr also contains:
Part of #4564