Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating saved annotations by searching annotations #4965

Merged
merged 21 commits into from
Sep 21, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Sep 13, 2023

This pull request tries to remove the need for anticipation of reuse when saving annotations. A saved annotation can easily be created by searching the list of existing annotations.

Clicking the link under the saved annotations searchfield:
image
Brings the user the the prefiltered saved annotations list page
image
This page now has a + button to create new saved annotations. This + button links to the prefiltered list of annotations:
image
These can of course be filtered or sorted as desired.

Here a user can easily save the annotation (I reused the existing modal for this)
image

The saved annotation detail page now also uses this list view of annotations instead of a list of submission:
image

This pr also contains:

  • bug fix: saved annotation titles sometimes incorrectly detected a duplicate
  • chore: the tracking of userId in the frontend to filter saved annotations is removed. The policy already always filters by current user.

Part of #4564

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Sep 13, 2023
@jorg-vr jorg-vr self-assigned this Sep 13, 2023
@jorg-vr jorg-vr changed the title Create index page for annotations Allow creating saved annotations by searching annotations Sep 19, 2023
@jorg-vr jorg-vr marked this pull request as ready for review September 19, 2023 08:52
@jorg-vr jorg-vr requested a review from a team as a code owner September 19, 2023 08:52
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team September 19, 2023 08:52
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the outlined button in the table instead of a primary

@chvp chvp added the deploy naos Request a deployment on naos label Sep 20, 2023
@chvp chvp temporarily deployed to naos September 20, 2023 12:49 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Sep 20, 2023
Copy link
Member

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As mentioned IRL, the button to save a comment doesn't seem to be translated sometimes.

(and we'll ignore the 403 as the beta will go away soon)

@jorg-vr jorg-vr requested a review from niknetniko September 21, 2023 08:54
@jorg-vr jorg-vr merged commit 32f2b01 into main Sep 21, 2023
9 of 13 checks passed
@jorg-vr jorg-vr deleted the feat/dont-require-anticipation-of-reuse branch September 21, 2023 10:02
@jorg-vr jorg-vr temporarily deployed to naos September 21, 2023 10:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants