Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating saved annotations by searching annotations #4965

Merged
merged 21 commits into from
Sep 21, 2023

Merge branch 'main' into feat/dont-require-anticipation-of-reuse

a9cc0fc
Select commit
Loading
Failed to load commit list.
Merged

Allow creating saved annotations by searching annotations #4965

Merge branch 'main' into feat/dont-require-anticipation-of-reuse
a9cc0fc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 21, 2023 in 1s

33.87% of diff hit (target 77.79%)

View this Pull Request on Codecov

33.87% of diff hit (target 77.79%)

Annotations

Check warning on line 29 in app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts#L29

Added line #L29 was not covered by tests

Check warning on line 31 in app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts#L31

Added line #L31 was not covered by tests

Check warning on line 66 in app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts#L65-L66

Added lines #L65 - L66 were not covered by tests

Check warning on line 100 in app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts#L99-L100

Added lines #L99 - L100 were not covered by tests

Check warning on line 111 in app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts#L109-L111

Added lines #L109 - L111 were not covered by tests

Check warning on line 113 in app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation.ts#L113

Added line #L113 was not covered by tests

Check warning on line 5 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L1-L5

Added lines #L1 - L5 were not covered by tests

Check warning on line 14 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L12-L14

Added lines #L12 - L14 were not covered by tests

Check warning on line 18 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L17-L18

Added lines #L17 - L18 were not covered by tests

Check warning on line 22 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L21-L22

Added lines #L21 - L22 were not covered by tests

Check warning on line 24 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L24

Added line #L24 was not covered by tests

Check warning on line 27 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L27

Added line #L27 was not covered by tests

Check warning on line 29 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L29

Added line #L29 was not covered by tests

Check warning on line 33 in app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/new_saved_annotation_link.ts#L32-L33

Added lines #L32 - L33 were not covered by tests

Check warning on line 58 in app/assets/javascripts/components/saved_annotations/saved_annotation_form.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/assets/javascripts/components/saved_annotations/saved_annotation_form.ts#L58

Added line #L58 was not covered by tests

Check warning on line 35 in app/controllers/saved_annotations_controller.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/saved_annotations_controller.rb#L35

Added line #L35 was not covered by tests

Check warning on line 47 in app/controllers/saved_annotations_controller.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/saved_annotations_controller.rb#L42-L47

Added lines #L42 - L47 were not covered by tests

Check warning on line 52 in app/controllers/saved_annotations_controller.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/saved_annotations_controller.rb#L51-L52

Added lines #L51 - L52 were not covered by tests