Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search by username in account linking flow #4967

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Sep 14, 2023

This pull request fixes finding a user by username in the account linking flow.

The search now uses the same values as:
image
Which is the goal as we want to prevent duplicate username errors.

  • a new test is added for this case

Closes #4966

@jorg-vr jorg-vr added the bug Something isn't working label Sep 14, 2023
@jorg-vr jorg-vr self-assigned this Sep 14, 2023
@jorg-vr jorg-vr marked this pull request as ready for review September 14, 2023 12:22
@jorg-vr jorg-vr requested a review from a team as a code owner September 14, 2023 12:22
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team September 14, 2023 12:22
@jorg-vr jorg-vr merged commit 704c264 into main Sep 14, 2023
15 checks passed
@jorg-vr jorg-vr deleted the fix/account-linking branch September 14, 2023 13:43
@jorg-vr jorg-vr temporarily deployed to naos September 14, 2023 13:44 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production September 14, 2023 13:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The flow to link accounts is broken
3 participants