-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csv differ support for empty rows #5864
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Additional
CSV.parse
Instances Found Require AttentionThe following files contain
CSV.parse
without thepadded_table
method applied:test/controllers/evaluations_controller_test.rb
app/helpers/renderers/csv_differ.rb
(already addressed)Please update these instances to use
padded_table
to maintain consistency in handling CSV data across the codebase.🔗 Analysis chain
LGTM! Changes align with PR objectives.
The integration of the
padded_table
method in theinitialize
method effectively addresses the issue of handling empty rows in CSV files. By applying this method to both@generated
and@expected
CSV data, we ensure that all rows have the same number of columns before further processing.To further verify the impact of these changes, we can run the following script to check for any other occurrences of CSV parsing in the codebase that might benefit from similar padding:
This will help us ensure consistency across the codebase in handling CSV data with potential empty rows.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 3030