Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create main function in entrypoint + rename entrypoint #26

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Create main function in entrypoint + rename entrypoint #26

merged 2 commits into from
Dec 4, 2021
+7 −4

Conversation

AbcSxyZ
Copy link
Contributor

@AbcSxyZ AbcSxyZ commented Dec 4, 2021 •
edited
Loading

Create a main function to call in entrypoint + rename docker-entrypoint.py

Facilitate import of entrypoint for test coverage in #25.

@AbcSxyZ AbcSxyZ changed the title Create main function in entrypoint Create main function in entrypoint + rename entrypoint Dec 4, 2021
@AbcSxyZ AbcSxyZ mentioned this pull request Dec 4, 2021
Open
@patricklodder
Copy link
Member

I was just working on fixing python lint suggestions and these were findings there... I'll rebase mine on top of yours.

patricklodder
patricklodder previously approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - code reviewed & tested to work on x86_64

@patricklodder patricklodder self-requested a review December 4, 2021 16:41
@patricklodder patricklodder dismissed their stale review December 4, 2021 16:42

I think I missed something

patricklodder
patricklodder requested changes Dec 4, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When rebasing my lint fixes on top of this, I found that the second commit overwrites the first commit's changes.

@patricklodder patricklodder mentioned this pull request Dec 4, 2021
Merged
@AbcSxyZ
Copy link
Contributor Author

AbcSxyZ commented Dec 4, 2021

Yep, commit troubles... Fixed.

@patricklodder patricklodder self-requested a review December 4, 2021 18:44
patricklodder
patricklodder approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - code reviewed and tested on x86_64, again 😁

@patricklodder patricklodder mentioned this pull request Dec 4, 2021
Merged
@patricklodder patricklodder added the enhancement New feature or request label Dec 4, 2021
xanimo
xanimo approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK also tested on amd64

@patricklodder patricklodder merged commit 335f326 into dogecoin:main Dec 4, 2021
@AbcSxyZ AbcSxyZ deleted the main-factoring branch December 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xanimo xanimo xanimo approved these changes

@patricklodder patricklodder patricklodder approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbcSxyZ @patricklodder @xanimo