-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CI test for files metadata #47
base: main
Are you sure you want to change the base?
Conversation
Need #48 to trigger tests. |
can you please rebase and try again? i checked out and rebased against upstream/main and it was able to detect the file additions and modifications: i'm just not certain if its caching a previous attempt with a test branch containing both #47 and #48 |
done |
Weird to see tests launching on your repo and not here... |
It's because your PR contain more commit, with some changes related to the Dockerfile ;) |
they shouldn't run here since i made a pr on my fork. can you try:
and open a pr against yourself? your commit should be behind #42 since it was merged earlier. i'd just like to see if this resolves #48 for you and if #48 is necessary. |
My branch is already rebased, check commits. I've a mysterious rebase check error I won't investigate tonight (I don't see why it complains after rebase...) , https://github.com/AbcSxyZ/docker/pull/14. I reopened the PR to relaunch tests, but nothing is triggered. #48 fix a syntax error |
sorry bud i don't mean to waste your time, but what i did to successfully get this to pass was on my local repo i ran:
then i fetch upstream (this can happen either before or after): then i interactively rebase your branch: and finally pushed which alleviated the:
you can see the error is thrown because your commit is the HEAD where as here it's 2 commits back from mains HEAD. in any case thanks for trying, i'll checkout #48 tomorrow. ❤️ |
I don't understand my problem with commits, my main is updated and my branch qa/files-metadata is rebased. I don't understand why my GA action is not launching (or failing, because it shouldn't start...) and I'm not sure about what you're asking me to do. It's late... |
so after looking at your error it's actually in your repo jitterbit is throwing error because the head commit of this pull request is not ahead of 'add tests path for workflow' commit
don't worry about it. your pr is fine. sorry for the trouble. will finish review of this and #48 tomorrow. |
It's even more confusing ! I don't understand why it asks to be ahead of a still pending PR. |
The reason on-push doesn't work for changing files is caused by rebase, because rebase changes history. I played with the thought for a moment to write a custom diff script but have not acted on that because it means even more maintenance pressure. Instead, the diff action currently only works for PRs and linear pushes, but not for force pushes. The way to test:
|
Fix #33
Convert tests + add a class to check files information inside containers.
Run CI tests
Will need some documentation to facilitate usage, but for now it's possible to run it using: