Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starknet-rs to use starknet-types-core Felt type #2177

Closed
tcoratger opened this issue Jul 15, 2024 · 3 comments
Closed

Update starknet-rs to use starknet-types-core Felt type #2177

tcoratger opened this issue Jul 15, 2024 · 3 comments

Comments

@tcoratger
Copy link
Contributor

With the recent merge of starknet-rs PR #562, it is now possible to update the project to the latest version of starknet-rs.

This update is particularly beneficial as it facilitates the migration from arkworks FieldElement to Felt types provided by starknet-types-core.

Benefits

  • Improved Compatibility: by using the Felt type from starknet-types-core, the codebase will be more aligned with the latest developments in the starknet-rs library.

Changes

  • Dependency Update: Updated the starknet-rs dependency to the latest version.
  • Type Migration: Replaced instances of arkworks FieldElement with starknet-types-core Felt type throughout the codebase.
@EjembiEmmanuel
Copy link
Contributor

@tcoratger I'd love to work on this as I'm already working on something related here #2161

@kariy
Copy link
Member

kariy commented Jul 15, 2024

the project is already migrated to use the new Felt type since #2126 but we're using a patch for starknet-rs while waiting for some upstream PRs to be merged. But now that xJonathanLEI/starknet-rs#615 has been merged, we may removed the patch and use rev 6a9f124 but there are some breaking changes need to be resolved possibly caused by xJonathanLEI/starknet-rs#617.

the new Felt is available in v1.0.0-alpha.0 but it's still relying on the aforementioned patches.

@EjembiEmmanuel
Copy link
Contributor

the project is already migrated to use the new Felt type since #2126 but we're using a patch for starknet-rs while waiting for some upstream PRs to be merged. But now that xJonathanLEI/starknet-rs#615 has been merged, we may removed the patch and use rev 6a9f124 but there are some breaking changes need to be resolved possibly caused by xJonathanLEI/starknet-rs#617.

oh okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants