Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patches from Cargo.toml #2452

Closed
tcoratger opened this issue Sep 19, 2024 · 2 comments · Fixed by #2454
Closed

Remove patches from Cargo.toml #2452

tcoratger opened this issue Sep 19, 2024 · 2 comments · Fixed by #2454

Comments

@tcoratger
Copy link
Contributor

Due to custom patches

dojo/Cargo.toml

Lines 248 to 253 in 5777c00

[patch.crates-io]
# Matching the same rev that `cainome` is using. Mainly because `starknet-rs` hasn't create a new release yet.
starknet = { git = "https://github.com/xJonathanLEI/starknet-rs", rev = "2ddc694" }
# This patch is required especially for `katana-db` to work properly.
# Ref: https://github.com/dojoengine/types-rs/commit/1943cb974a8738d2473d58479a3ace7badb0262f
starknet-types-core = { git = "https://github.com/dojoengine/types-rs", rev = "289e2f0" }

this is difficult to integrate Dojo as package due to dependency issues.

With the recent bump of starknet to 0.12 xJonathanLEI/starknet-rs#655 maybe we could bump the dependency.

xJonathanLEI/starknet-rs#657 should also be useful to remove all the patches as per this comment

dojo/Cargo.toml

Lines 242 to 245 in 5777c00

# `starknet-rs` is using `starknet-types-core` 0.1.3, but we need >=0.1.4 because
# we need this <https://github.com/starknet-io/types-rs/pull/75>. So we put strict
# requirement here to prevent from being downgraded.
# We can remove this requirement once `starknet-rs` is using >=0.1.4

@kariy
Copy link
Member

kariy commented Sep 19, 2024

@tcoratger thanks!

i had just taken look over our patches again, starknet's patches can be fully removed now. i would need to update it on the other deps as well, but for starknet-types-core we might still need a patch. the patch can now be pointed to main repo starknet-io/types-rs@245907a instead of our fork. let me try to ask the maintainer for a new patch release, so that we can remove the patch for it as well.

@tcoratger
Copy link
Contributor Author

@kariy I think this cartridge-gg/cainome#54 is also needed to remove all the patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants