-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship dokan1.dll #173
Comments
Hi @Rondom , From my experience, nuget has never been really great to handle native dependencies. It is possible but feel more like a hack than a nuget feature. After if there is a real request from the community, I would understand it and I would be alright to make it happen. |
I think the question is, "can we reasonably expect developers to have Dokan installed on their machines?" If people get it from nuget, I think it's safe to say "no, we can't." But on the flip side, if they try to run their code even in the presence of the DLL but without the driver, they won't get too far either. Would it be reasonable to put the requirement ("You must have Dokan installed, or else your filesystem will not load due to a missing DLL") in the license or other information dialog box that can optionally pop up when the Dokan.Net nuget package is installed? |
This can be an idea ! I do not know if it is possible at the nuget install to detect the presence of a dll (dokan1.dll). edit: Just seems to need to embed a Init.ps1 |
Please remember that Init.ps1 needs to be separately signed in order to operate on machines with the default PowerShell security profile. |
I'm thinking this will prevent the exception |
Given that applications are supposed to have their own copy of dokan1.dll, I am wondering whether the nuget-package should ship dokan1.dll or whether there should be a separate nuget-package or vcpkg-package with dokan1.dll that the .NET nuget-package depends on.
What are the best practices regarding this? What do other C# libraries with dependencies on C-libraries do?
The text was updated successfully, but these errors were encountered: