Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the Firefox version older than the Chrome version? #32

Closed
gioxx opened this issue May 14, 2023 · 4 comments
Closed

Why is the Firefox version older than the Chrome version? #32

gioxx opened this issue May 14, 2023 · 4 comments

Comments

@gioxx
Copy link
Contributor

gioxx commented May 14, 2023

As stated in the subject. @doma-itachi you know that I've been using your extension since you released the first version and I find it essential, but I don't understand why there are several PRs that have been open for a long time but stopped there and - most importantly - why the Firefox version lags behind the Chrome version.
Can I help you in any way?

In the meantime, I can confirm the problem reported in bug #30 and that I now see Shorts also on the main page of the YouTube account:

immagine

Thanks!
Giovanni.

@doma-itachi
Copy link
Owner

I pushed v1.4.0fx (untested). (26cc1a9)

Thanks for the great suggestion! And sorry for your concerns.
Here are my concerns with the Firefox version (& others)
Some of them are off topic, but please bear with me.

  1. about "Hide shorts video
    Hide shorts video" has been disabled by default for a long time. However, since the Chrome version was often unaware of the configuration (it's a UX issue for extensions that users are unaware of) and often gave low ratings, it was enabled by default in v1.4.0. (Enable "hide shorts video" option by default #23 )
    However, I am wondering if we can take that behavior directly to the Firefox version (few such reviews on AMO)

In the meantime, I have the following countermeasures in mind

  • Display a guide on first startup after installation
  • Show somewhere in the Youtube UI that shorts are blocked
  1. the name of the "Youtube-shorts block" (Add more icons and fix strings and manifest.json #24)
    In PR Add more icons and fix strings and manifest.json #24, the name was changed to "Youtube Shorts Block".
    We have been using the name "Youtube-shorts block" since the beginning of the project, but for foreign language users, do you feel uncomfortable with this hyphenated name? (I live in Japan and am not very fluent in English.)

I am thinking of making the code common between Chrome and Firefox. (by if statements or tools).

@doma-itachi
Copy link
Owner

v1.4.1 has released to AMO :)

@GreyAsteroid
Copy link

v1.4.1 has released to AMO :)

Did something go awry with this release? The add-on page for this still shows 1.3.4 as the latest version.

@doma-itachi
Copy link
Owner

Hmm...
It appears that mozilla has not yet completed the review process.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants