Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @testing-library/dom to v10 #7

Open
jwm01cg opened this issue May 17, 2024 · 3 comments
Open

Update @testing-library/dom to v10 #7

jwm01cg opened this issue May 17, 2024 · 3 comments

Comments

@jwm01cg
Copy link

jwm01cg commented May 17, 2024

  • I'm submitting a ...
    [ ] bug report
    [x] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary
    Thanks for this package - we use it in all of our tests to keep them tidy and use models of the page to build our assertions. We would like to upgrade to @testing-library/react v15, however this brings the version of @testing-library/dom to v10 with this package still using v9 as a peer dependency. This causes a lot of errors about act() usage in our logs.

@jwm01cg jwm01cg changed the title Updat @testing-library/dom to v10 Update @testing-library/dom to v10 May 17, 2024
@Narbe66
Copy link

Narbe66 commented Jul 25, 2024

Is there any update to this issue?

@patii132
Copy link

patii132 commented Aug 1, 2024

Unfortunately, we are currently unable to perform an Angular 18 upgrade as it is not supported. Is there an update, when and if it will happen?

@Narbe66
Copy link

Narbe66 commented Aug 5, 2024

Just fixed it by overriding npm peer dependency. Just add

"overrides": {
    "testing-library-selector": {
      "@testing-library/dom": "^10.0.0"
    }
  }

to the end of your package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants