Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: in _validate_hardware_tier_id #174

Open
dmbaker opened this issue Jun 9, 2023 · 4 comments
Open

BUG: in _validate_hardware_tier_id #174

dmbaker opened this issue Jun 9, 2023 · 4 comments

Comments

@dmbaker
Copy link

dmbaker commented Jun 9, 2023

BUG!!!

This method is being passed a dict in the parameter hardware_tier_id, but the equality test expects a string!

1152 if hardware_tier_id == hardware_tier["hardwareTier"]["id"]:
1153 return True
-> 1154 raise exceptions.HardwareTierNotFoundException(
1155 f"{hardware_tier_id} hardware tier Id not found"
1156 )

HardwareTierNotFoundException: {'value': 'small-k8s'} hardware tier Id not found

@dmbaker
Copy link
Author

dmbaker commented Jun 9, 2023

Either pass a string, or on line 1152 to this:

1152 if hardware_tier_id['value'] == hardware_tier["hardwareTier"]["id"]:

@ddl-alexpanin
Copy link
Contributor

@dmbaker could you please clarify, which line of code sends hardware_tier_id as a dict and not as a string to _validate_hardware_tier_id method?

@dmbaker
Copy link
Author

dmbaker commented Jun 18, 2023

@ddl-alexpanin, I have not been able to trace that. The error happens when I try to round trip the computeCluster value of a domino.job_status return as an argument compute_cluster_properties.

@ddl-alexpanin
Copy link
Contributor

Thanks @dmbaker! If you have a full stack trace with the error, not only the latest line, it will help a lot!

I will send these findings to our QE anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants