Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdp:lead_time_for_change:by_commit should include the image sha that it was matched with as a label #1088

Open
1 task done
etsauer opened this issue Oct 18, 2023 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@etsauer
Copy link
Collaborator

etsauer commented Oct 18, 2023

Feature description

The lead time for change measure combines two different metrics:

  • commit_timestamp - uniquely identified by a commit sha
  • deploy_timestamp - uniquely identified by an image sha

Currently when we query sdp:lead_time:by_commit we get results that look like:

sdp:lead_time:by_commit{app="/pelorus-api/", commit="159c63792a5c1b0d34902be8bc2280406ad1ef06"}

This gives us only the commit id. this metric should also list the image sha, since it should be a one-to-one mapping.

How this will help you

This will give us better traceability for data validation

Feature priority

⌛ It will greatly improve my experience using Pelorus

Code of Conduct

  • I agree to follow Pelorus's Code of Conduct
@etsauer etsauer added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

1 participant