Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Experience: allow pelorus devs to use ZSH #1143

Open
1 task done
etsauer opened this issue Jul 11, 2024 · 0 comments
Open
1 task done

Developer Experience: allow pelorus devs to use ZSH #1143

etsauer opened this issue Jul 11, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@etsauer
Copy link
Collaborator

etsauer commented Jul 11, 2024

OpenShift version

Not related to OpenShift

Problem description

I've recently run across a situation where I wanted to set up a pelorus development environment in a workspace where I was using ZSHELL. This doesn't work because some of our scripts rely on bash specific environment variables

Steps to reproduce

  1. install zsh
  2. switch to a zsh terminal by running zsh
  3. run make dev-env

Current behavior

make dev-env will fail with an error like the following:

Downloading https://get.helm.sh/helm-v3.15.3-linux-amd64.tar.gz
Preparing to install helm into .venv/bin
helm installed into .venv/bin/helm
helm is /projects/pelorus/.venv/bin/helm
Installing tkn CLI to: .venv/bin/tkn
Traceback (most recent call last):
  File "/projects/pelorus/scripts/get_tool_dl_url.py", line 12, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'
Cleaning up temporary files
make: *** [Makefile:75: cli_dev_tools] Error 2

Expected behavior

make dev-env should succeed. I expect there are probably a few other areas besides this one that would need cleaned up in order to allow zsh users to use the scripts, but we won't know until we get past this one.

Code of Conduct

  • I agree to follow Pelorus's Code of Conduct
@etsauer etsauer added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

1 participant