-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow and Type Errors added to concept.py . Required tests for qua… #77
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca218c1
Overflow and Type Errors added to concept.py . Required tests for qua…
Vortex-21 ad78f8d
minor issues fixed
Vortex-21 fb1209a
code formatted
Vortex-21 0270c03
python-version file removed
Vortex-21 9185513
Removed TypeError for None and updated tests
Vortex-21 59ede20
test_cdaannotator updated
Vortex-21 3ca8d30
Merge branch 'main' into main
adamkells File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,3 +164,4 @@ scrap/ | |
.DS_Store | ||
.vscode/ | ||
.ruff_cache/ | ||
.python-version |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import pytest | ||
from healthchain.models.data.concept import Quantity | ||
from pydantic import ValidationError | ||
|
||
|
||
# Valid Cases | ||
def test_valid_float_and_integer(): | ||
valid_floats = [1.0, 0.1, 4.0, 5.99999, 12455.321, 33, 1234] | ||
for num in valid_floats: | ||
q = Quantity(value=num, unit="mg") | ||
assert q.value == num | ||
|
||
|
||
def test_valid_string(): | ||
valid_strings = ["100", "100.000001", ".1", "1.", ".123", "1234.", "123989"] | ||
for string in valid_strings: | ||
q = Quantity(value=string, unit="mg") | ||
assert q.value == float(string) | ||
|
||
|
||
# Invalid Cases | ||
def test_invalid_strings(): | ||
invalid_strings = [ | ||
"1.0.0", | ||
"1..123", | ||
"..123", | ||
"12..", | ||
"12a.56", | ||
"1e4.6", | ||
"12#.45", | ||
"12.12@3", | ||
"12@3", | ||
] | ||
for string in invalid_strings: | ||
with pytest.raises(ValidationError) as exception_info: | ||
Quantity(value=string, unit="mg") | ||
assert "Invalid value" in str(exception_info.value) | ||
|
||
|
||
# Edge Cases | ||
def test_edge_cases(): | ||
edge_cases = ["", "None", None] | ||
for val in edge_cases: | ||
with pytest.raises((ValidationError, TypeError)) as exception_info: | ||
Quantity(value=val, unit="mg") | ||
|
||
exception_info_str = str(exception_info.value) | ||
assert any(msg in exception_info_str for msg in ["CANNOT", "Invalid value"]) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the testing suite and got some errors from this line. The logic here should be slightly different. If None is passed in then we want to just return None back, however if a type other than str or float is passed then we can raise the warning. I've added a suggestion below (written on my phone so will need some edits).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay got it ! Will make the change.