Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase text-heading margins slightly #73

Open
PeterRydberg opened this issue Jan 15, 2021 · 0 comments
Open

Increase text-heading margins slightly #73

PeterRydberg opened this issue Jan 15, 2021 · 0 comments

Comments

@PeterRydberg
Copy link

Is your feature request related to a problem? Please describe.
Most of the text is just a little too close to feel natural.

Describe the solution you'd like
Sectioning off different blocks of text is easier when there's a little more space between them.

Describe alternatives you've considered
I have a few suggestions. Keep in mind that I do not know the exact measurements of the different variables used, so I'm going with ems.

  • Paragraph to heading below the chart should be 2em (is var(--spacing-4))
  • Grid gap in info-box should be 2em (is var(--spacing-4)). The gaps in the internal text inside each div is fine, I think.
  • The font size on each item (e.g Norsk) is a little too close in size to the heading above. Should be 1.25em (is var(--font-size-lg)).

Additional context
The info box should look like this (using the CSS from #71):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant