Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for setting up Nginx #33132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kant2002
Copy link

@kant2002 kant2002 commented Jul 22, 2024

Fixes #33159


Internal previews

📄 File 🔗 Preview link
aspnetcore/host-and-deploy/linux-nginx.md Host ASP.NET Core on Linux with Nginx

@Rick-Anderson
Copy link
Contributor

@kant2002 I don't see any differences. What's changed?

@kant2002
Copy link
Author

I remove http. Since that’s part inside nginx.conf where sites-available included

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Jul 24, 2024

@kant2002 got it thanks, just these two changes?

image

Per CoPilot, the only difference is the http block has been removed.

@kant2002 Is the following correct?
The http block not necessary as it's the default context in Nginx configuration files

@javiercn please review

@kant2002
Copy link
Author

@Rick-Anderson yes. it's correct.

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no context on how this setup works.

@BrennanConroy knows better I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Nginx instructions
3 participants