Fixing default print newline

[ozanMSFT]

Fixes #1414

We're attempting to add back the default newLine as \n to have correct results in Jupyter notebooks.

[yueyinqiu]

A hardcoded "\n" might not be that feasible since we may like "\r\n" or something else on other platforms.

And I suppose what we should do is to switch the default value from "" to null. Then it will use torch.newLine:

TorchSharp/src/TorchSharp/Tensor/Tensor.cs

Line 6523 in 458b77e

var nl = newLine is null ? torch.newLine : newLine;

And... These lines are useless since we are later passing nl instead of newLine:

TorchSharp/src/TorchSharp/Tensor/Tensor.cs

Line 6526 in 458b77e

if (String.IsNullOrEmpty(newLine))

So maybe remove it?

[yueyinqiu]

By the way maybe we shall set the original console.out back? I don't know ((

[ozanMSFT]

@dotnet-policy-service agree company="Microsoft"

[ozanMSFT]

A hardcoded "\n" might not be that feasible since we may like "\r\n" or something else on other platforms.

And I suppose what we should do is to switch the default value from "" to null. Then it will use torch.newLine:

TorchSharp/src/TorchSharp/Tensor/Tensor.cs

Line 6523 in 458b77e

var nl = newLine is null ? torch.newLine : newLine;

And... These lines are useless since we are later passing nl instead of newLine:

TorchSharp/src/TorchSharp/Tensor/Tensor.cs

Line 6526 in 458b77e

if (String.IsNullOrEmpty(newLine))

So maybe remove it?

Thanks for the comments. I've used \n to be consistent with other methods within TensorExtensionMethods.cs

Maybe we can consider to replace others to null to force OS to use its default new line but I think it can be a scope for another PR with your other suggestions for refactoring.

For this one, only focusing on fixing print issue.

[yueyinqiu]

Oh I didn't notice that. Maybe we shall reconsider that later.