Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building the managed part without node installed doesn't work anymore #59114

Open
ViktorHofer opened this issue Nov 22, 2024 · 0 comments · May be fixed by #59118
Open

Building the managed part without node installed doesn't work anymore #59114

ViktorHofer opened this issue Nov 22, 2024 · 0 comments · May be fixed by #59118
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@ViktorHofer
Copy link
Member

Potentially regressed with #58721

    C:\git\dotnet\src\aspnetcore\src\Assets\Microsoft.AspNetCore.App.Internal.Assets.csproj(46,5): error : 'C:\git\dotnet\src\aspnetcore\src\Components\Web.JS\dist\Rel
  ease\blazor.web.js' does not exist. Run 'npm run build' in the repo root to generate the file.
    C:\git\dotnet\src\aspnetcore\src\Components\WebView\WebView\src\Microsoft.AspNetCore.Components.WebView.csproj(68,5): error : '..\..\..\Web.JS\dist\Release\blazor.
  webview.js' does not exist. Falling back to checked-in copy.
    CSC : error CS1566: Error reading resource '_framework/blazor.webview.js' -- 'Could not find a part of the path 'C:\git\dotnet\src\aspnetcore\src\Components\Web.JS
  \dist\Release\blazor.webview.js'.' [C:\git\dotnet\src\aspnetcore\src\Components\WebView\WebView\src\Microsoft.AspNetCore.Components.WebView.csproj]

Also note that this logic doesn't work anymore:

aspnetcore/src/Components/WebView/WebView/src/Microsoft.AspNetCore.Components.WebView.csproj

Line 68 in 3ba179a

<Warning Text="'$(BlazorWebViewJSFile)' does not exist. Falling back to checked-in copy." />

CI triggers a dev workflow job that validates certain dev scenario but building the managed part with --no-build-nodejs unfortunately isn't validated.

cc @MackinnonBuck
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 22, 2024
@MackinnonBuck MackinnonBuck linked a pull request Nov 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix source build when using --no-build-js dotnet/aspnetcore
1 participant
@ViktorHofer