-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ref and runtime packs to use the SharedFramework SDK and Arcade's installer tooling #58612
Open
jkoritzinsky
wants to merge
56
commits into
dotnet:main
Choose a base branch
from
jkoritzinsky:sfx-aspnetcore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+711
−3,774
Open
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
ff532f2
Add an sfxproj for the ref pack for Microsoft.AspNetCore.App. IT has …
jkoritzinsky c26b20d
Add sfxproj-based runtime framework project
jkoritzinsky 1ff7845
Produce the targeting pack archives
jkoritzinsky 789e9bf
Build the runtime archive. There's some extra rebuilding now, so need…
jkoritzinsky edd7c4e
Add a (mostly correct, some TODOs) composite runtime image and archive.
jkoritzinsky ef9422e
Use traversal projects to ensure that building the runtime archive pr…
jkoritzinsky 4b6dd92
Add the new .deb packaging to the targeting pack
jkoritzinsky f6de9ec
Add the aspnetcore runtime deb package to the sfxproj
jkoritzinsky ad492ac
Enable building RPM packages
jkoritzinsky cf0e833
Publish from the new-style projects to the correct subfolders for con…
jkoritzinsky 8590cb7
Remove a TODO that's being addressed
jkoritzinsky f5ab929
Add support for partial R2R rooting based on https://github.com/dotne…
jkoritzinsky 28a3d39
Reuse global properties and remove TODO addresed in corresponding Arc…
jkoritzinsky 8df753c
Replace old shared framework projects and Linux installers with the n…
jkoritzinsky ec21b15
Remove the NoTargets SDK, ended up using the Traversal SDK instead.
jkoritzinsky 214ede2
Fix path to runtime pack for manifest
jkoritzinsky d46c78a
Don't reference the installers package on Windows. We don't want to b…
jkoritzinsky 940cba6
Fix reference from aspnetcore-runtime and sequence the projects into …
jkoritzinsky 46431f2
Profive projects to build when only -buildinstallers is passed. This …
jkoritzinsky d19ea9a
Fix the path of the runtime list for testing.
jkoritzinsky 332b97b
Set property with file name
jkoritzinsky 3e7e74b
Disable APICompat for the archive projects.
jkoritzinsky ffc4ecf
Fix expected output directory for deb/rpm/targz/zip to be the shippin…
jkoritzinsky b176f09
Fix including zips (as wixpacks are still in the intsallers folder)
jkoritzinsky 5ed00aa
Build the shared frameworks via the transitive SDK proj only and make…
jkoritzinsky 58ce10e
Merge branch 'sfx-aspnetcore' of github.com:jkoritzinsky/aspnetcore i…
jkoritzinsky faa4b35
Merge branch 'main' of https://github.com/dotnet/aspnetcore into sfx-…
jkoritzinsky 7d00f4c
Add PGO data via direct references to the MIBC files instead of flowi…
jkoritzinsky b274123
Don't exclude the runtime archive traversal proj from the source-only…
jkoritzinsky 18fe593
Add some makedirs
jkoritzinsky 49187e3
Merge branch 'main' of github.com:dotnet/aspnetcore into sfx-aspnetcore
jkoritzinsky c6c4e71
Don't try to extract the runtime we skipped downloading
jkoritzinsky b84d04d
Always prefer the ref assemblies in the transport pack over the impl …
jkoritzinsky e712bc7
Add the right PackageOverrides.txt entries and make sure we exclude a…
jkoritzinsky 110adb8
Merge branch 'main' of https://github.com/dotnet/aspnetcore into sfx-…
jkoritzinsky 801f78b
Enable building all projects using the sharedfx sdk in source-build
jkoritzinsky cd60089
Don't exclude the composite archive from source build.
jkoritzinsky 0ba6470
Write out the aspnetcore_base_runtime.version file
jkoritzinsky 80bfc79
Update aspnetcore-base-runtime.proj
jkoritzinsky 1795fc9
Don't R2R when explicitly requested not to
jkoritzinsky ad87dc3
Merge branch 'main' of https://github.com/dotnet/aspnetcore into sfx-…
jkoritzinsky 44e287e
Merge branch 'main' into sfx-aspnetcore
jkoritzinsky b1b144d
Update .NET SDK to get composite image fix
jkoritzinsky b6ff5fb
Use the new RPM tooling and build debs/rpms in the regular build step…
jkoritzinsky 6aed496
Remove rpmpkg references and update ref pack baseline version
jkoritzinsky 555c39e
Fix version string
jkoritzinsky 72f970c
Remove installers group on Build.props as the "managed" build will no…
jkoritzinsky 0b25d0e
Use Arcade RPM tooling for the Runtime sfxproj
jkoritzinsky 1f1faf6
Revert "Update .NET SDK to get composite image fix"
jkoritzinsky ba90cf1
Merge branch 'main' of https://github.com/dotnet/aspnetcore into sfx-…
jkoritzinsky 482c5e4
Merge branch 'main' of github.com:dotnet/aspnetcore into sfx-aspnetcore
jkoritzinsky b03e202
Merge branch 'main' of github.com:dotnet/aspnetcore into sfx-aspnetcore
jkoritzinsky ed7c875
Don't pack the ref pack when only packing rid-specific packages
jkoritzinsky f1a7846
Remove RpmOwnedDirectory items as they're now provided by the SharedF…
jkoritzinsky cd7c2c6
Don't build installers in source-build
jkoritzinsky 0d1edd2
Merge branch 'main' into sfx-aspnetcore
RussKie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the common pattern to publish installers to the
packages
dir?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, dotnet/runtime and dotnet/windowsdesktop publish all installers to the
packages
dir.