Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Mistakes in the Documentation #5248

Closed
mikebelluk opened this issue May 9, 2018 — with docs.microsoft.com · 1 comment · May be fixed by #43630
Closed

Two Mistakes in the Documentation #5248

mikebelluk opened this issue May 9, 2018 — with docs.microsoft.com · 1 comment · May be fixed by #43630
Assignees
Labels
dotnet-ml/svc in-pr This issue will be closed (fixed) by an active pull request. ⌚ Not Triaged Not triaged

Comments

Copy link

Hi,

I spotted a couple of issues with the documentation..

  1. You need to return the model in the Train method, e.g.

PredictionModel<TaxiTrip, TaxiTripFarePrediction> model = pipeline.Train<TaxiTrip, TaxiTripFarePrediction>();
await model.WriteAsync(ModelPath);

return model;

  1. When running the example, I get the error "Source column 'fare_amount' not found". This can be fixed by changing TaxiTrip.cs from:

[Column(ordinal: "6", "Label")]
public float fare_amount;

..to..

[Column(ordinal: "6", name: "fare_amount")]
public float fare_amount;

I suspect though, that this should have been handled by the ColumnCopier line:
pipeline.Add(new ColumnCopier(("fare_amount", "Label")));

Mike


Document details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@BillWagner
Copy link
Member

Thanks for spotting this @mikebelluk

This is fixed in #5245 You can see the code changes in dotnet/samples#57 Those changes should be published today or tomorrow.

I'm going to close this. But, if you don't think that fixes the problem, reopen this.

@mairaw mairaw added this to the Sprint 135 (4/28/18 - 5/18/18) milestone May 10, 2018
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Feb 9, 2021
iliar-turdushev added a commit to iliar-turdushev/dotnet-docs that referenced this issue Nov 18, 2024
Adds description how to disable retries for some HTTP methods
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-ml/svc in-pr This issue will be closed (fixed) by an active pull request. ⌚ Not Triaged Not triaged
Projects
None yet
4 participants