Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove existing APIs from the missing API list #10829

Merged
merged 19 commits into from
Mar 4, 2019
Merged

remove existing APIs from the missing API list #10829

merged 19 commits into from
Mar 4, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Feb 28, 2019 •
edited
Loading

APIs have been onboarded and redirection is bad at the moment

Dependent on PR #10858

@mairaw mairaw added this to the March 2019 milestone Feb 28, 2019
@mairaw mairaw self-assigned this Feb 28, 2019
rpetrusha
rpetrusha approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I left one comment for you to consider.

_zip/missingapi.yml Outdated
@@ -19,7 +19,7 @@ references:
name.vb: ToString
fullName: XDocument.ToString
fullName.vb: XDocument.ToString
- uid: System​.Runtime​.CompilerServices.IndexerNameAttribute
- uid: System.Runtime.CompilerServices.IndexerNameAttribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a missing API: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.indexernameattribute

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10829
Advanced (Windows Presentation Foundation)
2 minutes to read • Edit Online
In ThisSection
This section describes some of theadvanced areas in WPF.
WPF Architecture
XAML in WPF
BaseElement Classes
ElementTreeand Serialization
WPF Property System
Events in WPF
Input
Drag and Drop
Resources
Documents
Globalization and Localization
Layout
Migration and Interoperability
Performance
Threading Model
Unmanaged WPF API Reference

@mairaw
Copy link
Contributor Author

mairaw commented Mar 1, 2019

Thanks @rpetrusha. Your comment made me realize we could probably remove much more APIs.

Kept the ones that are still missing and opened an mdoc issue:
mono/api-doc-tools#426

@mairaw mairaw changed the title remove UWP APIs from the missing API list remove existing APIs from the missing API list Mar 1, 2019
@mairaw mairaw requested a review from BillWagner as a code owner March 1, 2019 19:11
@mairaw mairaw added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Mar 1, 2019
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Mar 4, 2019
@mairaw mairaw merged commit 0d45db2 into master Mar 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-2 branch March 4, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanti3 kanti3 kanti3 left review comments

@rpetrusha rpetrusha rpetrusha approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

@mairaw mairaw

Labels
None yet
Projects
None yet
Milestone
March 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @rpetrusha @kanti3