Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and reuse code around temp dirs in FSharp.Compiler.Service.Tests #18046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify and reuse code around temp dirs in FSharp.Compiler.Service.Tests #18046

wants to merge 2 commits into from
+54 −119

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Nov 22, 2024

Description

TestFramework module from Test.Utilities provides functionality for creating and cleanup of temp directories and files for testing.
There is a lot of similar code in FSharp.Compiler.Service.Tests that can be simplified now.

Fixes

Some flakiness around creating deleting / directories, for example:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=875794&view=logs&j=170942dc-5349-5022-2275-77744f335216&t=20776a93-33c2-52f0-ee8f-b8c9809b2e23&l=16230

  Failed FSharp.Compiler.Service.Tests.ExprTests.Test Operator Declarations for IntPtr [5 ms]
  Error Message:
   System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\Users\cloudtest\AppData\Local\Temp\FSharp.Test.Utilities\ab3ae841\ExprTests\92147ee0_8116_18.fs'.

@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

@majocha majocha marked this pull request as ready for review November 22, 2024 09:24
@majocha majocha requested a review from a team as a code owner November 22, 2024 09:24
KevinRansom
KevinRansom approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks for taking care of this. I never have the energy to work on it, so I really appreciate this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majocha @KevinRansom