Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test templates to SDK repo #44417

Open
wants to merge 21 commits into
base: release/9.0.2xx
Choose a base branch
from

Conversation

Evangelink
Copy link
Member

Fixes #44416

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Oct 23, 2024
@Evangelink Evangelink marked this pull request as ready for review November 21, 2024 09:24
@Evangelink Evangelink requested a review from a team as a code owner November 21, 2024 09:24
@Evangelink
Copy link
Member Author

@marcpopMSFT I don't know if you have some acceptance tests that check the template can be created and if they automatically run all templates?

@marcpopMSFT
Copy link
Member

@Evangelink search through this file to see if we're targeting the specific templates that were moved over: https://github.com/dotnet/sdk/blob/release/9.0.2xx/test/EndToEnd.Tests/ProjectBuildTests.cs#L342

I guess there's nothing that confirms it's using the templates you're inserting here versus some other version of the templates (say the stage 0 version). You'd have to review the binlog to confirm that I think.

@Evangelink
Copy link
Member Author

@dotnet/templating-engine-maintainers This is ready for review.

There are many basic tests, it might be worth to add more for specific feature for test projects but we didn't have them previously so I don't think it should prevent merging.

@marcpopMSFT
Copy link
Member

Did you confirm manually that the new templates are getting picked up in the zip and other installs? Can you add an update to the codeowners file?

Not sure what else we'd be reviewing here.

@Evangelink
Copy link
Member Author

Did you confirm manually that the new templates are getting picked up in the zip and other installs?

I assumed that if the dotnet new tests were working it was all good but I will confirm that now from a fresh build.

Can you add an update to the codeowners file?

Done. Please review, given there is limited pattern support I kept template team for all changes to template and added us for the test related templates.

@Evangelink
Copy link
Member Author

Templates are correctly included:

image

image

but it made me realize that I need to update code so we stop using/packing the test template:

image

@Evangelink Evangelink added Area-Templates and removed untriaged Request triage from a team member labels Nov 26, 2024
@Evangelink
Copy link
Member Author

Now it should be all good @marcpopMSFT

@Evangelink
Copy link
Member Author

@marcpopMSFT I'd appreciate if we could move forward this PR because it's now causing conflicts every time the current templates gets inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants