-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test templates to SDK repo #44417
base: release/9.0.2xx
Are you sure you want to change the base?
Conversation
@marcpopMSFT I don't know if you have some acceptance tests that check the template can be created and if they automatically run all templates? |
@Evangelink search through this file to see if we're targeting the specific templates that were moved over: https://github.com/dotnet/sdk/blob/release/9.0.2xx/test/EndToEnd.Tests/ProjectBuildTests.cs#L342 I guess there's nothing that confirms it's using the templates you're inserting here versus some other version of the templates (say the stage 0 version). You'd have to review the binlog to confirm that I think. |
@dotnet/templating-engine-maintainers This is ready for review. There are many basic tests, it might be worth to add more for specific feature for test projects but we didn't have them previously so I don't think it should prevent merging. |
Did you confirm manually that the new templates are getting picked up in the zip and other installs? Can you add an update to the codeowners file? Not sure what else we'd be reviewing here. |
I assumed that if the
Done. Please review, given there is limited pattern support I kept template team for all changes to template and added us for the test related templates. |
Now it should be all good @marcpopMSFT |
@marcpopMSFT I'd appreciate if we could move forward this PR because it's now causing conflicts every time the current templates gets inserted. |
Fixes #44416