Fixing HighContrast theme in Fluent #10094
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
harshit7962
approved these changes
Nov 29, 2024
| @@ -83,7 +83,7 @@ | |||
|
|
|||
| <SolidColorBrush x:Key="ControlSolidFillColorDefaultBrush" Color="{StaticResource SystemColorButtonFaceColor}" /> | |||
|
|
|||
| <SolidColorBrush x:Key="SystemColorWindowColorBrush" Color="Transparent" /> | |||
| <SolidColorBrush x:Key="SubtleFillColorTransparentBrush" Color="Transparent" /> | |||
There was a problem hiding this comment.
I don't see this resource being used anywhere. Is this part of our parity work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # #10043
Main PR
Description
While fixing TemplateBinding for different controls, some resource keys in HC.xaml got duplicated, which when loaded causes the above issue.
Customer Impact
Developers will be able to use Fluent in HighContrast mode.
Regression
Yes, as compared to .NET 9 Preview 4 release.
Testing
Ad-hoc testing.
Risk
Minimal.
Microsoft Reviewers: Open in CodeFlow