Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks SuperTable in Matrix View #7

Closed
theskyfloor opened this issue Jul 10, 2018 · 7 comments
Closed

Breaks SuperTable in Matrix View #7

theskyfloor opened this issue Jul 10, 2018 · 7 comments
Assignees
@joshangell
Labels
Bug Report Something isn't working

Comments

@theskyfloor
Copy link

If I use a Matrix within a Matrix and SuperTable is set to Matrix layout no blocks or content shows up.

Enabled:

screen shot 2018-07-10 at 7 51 49 am

Disabled:

screen shot 2018-07-10 at 7 51 26 am
@theskyfloor
Copy link
Author

I should add that Spoon works correctly when the SuperTable field is set to Table or Row layout

@theskyfloor
Copy link
Author

Actually, that isn't entirely true. Fields initialize correctly when I create a new block/row but when I save and refresh they no longer appear (at least for my plain text field test):

screen shot 2018-07-10 at 7 57 17 am

@joshangell
Copy link
Contributor

Aaah yes, is this basically the same issue? angell-co/Pimp-My-Matrix#40

@joshangell joshangell self-assigned this Jul 10, 2018
@joshangell joshangell added the Bug Report Something isn't working label Jul 10, 2018
@theskyfloor
Copy link
Author

Looks similar!

@joshangell
Copy link
Contributor

Cool, I’ve added it to the roadmap :)

joshangell added a commit that referenced this issue Aug 29, 2018
@joshangell
Only hide fields that are the direct decendent of the valid matrix bl…
eae4ad3 
…ock.

Goes some way to helping #7
@joshangell
Copy link
Contributor

joshangell commented Aug 29, 2018 •
edited
Loading

Update: this is partially fixed in that you can now see the fields, but the buttons and settings menus are pretty broken.

And those issues are true for all the Super Table layout options.

joshangell added a commit that referenced this issue Aug 29, 2018
@joshangell
Merge tag '3.1.0' into develop
ee3332d 
- Now the global settings page shows you the parent field if the Matrix field is contained in a Super Table block

- Fixed an issue with the settings model rules not being declared properly
- Fixed an issue where sometimes the loader js wasn’t getting run
- Fixed an issue where no fields would show if the Matrix field being spooned was inside another Matrix field some how, tested inside Super Table ([#7](#7))

* tag '3.1.0':
  Changelog for 3.1.0
@joshangell
Copy link
Contributor

Added support for Super Table allowing you to use Spoon on Matrix fields that are inside Super Table fields, both Super Table > Matrix and Matrix > Super Table > Matrix.

Initially this is only for the global context which means you can only change these nested Matrix fields in the Spoon settings page and those changes apply everywhere.

See #19 for updates on that.

@ricdev ricdev mentioned this issue Sep 13, 2018
Closed
@joshangell joshangell mentioned this issue Jan 17, 2019
Closed
@heymarkreeves heymarkreeves mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshangell joshangell

Labels
Bug Report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshangell @theskyfloor