Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the user when saving an image #17

Open
douglascdev opened this issue Apr 24, 2022 · 1 comment
Open

Inform the user when saving an image #17

douglascdev opened this issue Apr 24, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@douglascdev
Copy link
Owner

douglascdev commented Apr 24, 2022

The current saving function writes to the console to say the image was saved. It should show a dialog with text saying whether it saved successfully(and the path, if so) or if there was an error, say so and log the exception.

Instead of a dialog, it would make more sense to do it like vim and show the message in #15's input after writing :w, so this issue now depends on #15 being completed.

@douglascdev douglascdev added enhancement New feature or request good first issue Good for newcomers labels Apr 24, 2022
@douglascdev douglascdev reopened this Apr 25, 2022
@douglascdev douglascdev changed the title Show a dialog when saving an image Inform the user when saving an image Apr 25, 2022
@douglascdev
Copy link
Owner Author

douglascdev commented Apr 25, 2022

@Bleit51 I saw you forked the repo just before I edited this issue, were you going to try solving this one? Sorry If that was the case. And if so, please wait until #15 is done and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant