Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving genre tag in <textClass> #55

Closed
lucagiovannini7 opened this issue May 2, 2024 · 3 comments
Closed

Improving genre tag in <textClass> #55

lucagiovannini7 opened this issue May 2, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@lucagiovannini7
Copy link
Member

Plays where the textual genre is indicated follow this simpler markup

 <textClass>
  <classCode scheme="http://www.wikidata.org/entity/">Q80930</classCode>
 </textClass>

instead of the DraCor standard

<textClass>
  <keywords>
    <term type="genreTitle">Comedy</term>
  </keywords>
  <classCode scheme="http://www.wikidata.org/entity/">Q40831</classCode>
</textClass>

Should we reintroduce the keywords element?

@cmil cmil added the duplicate This issue or pull request already exists label May 2, 2024
@cmil
Copy link
Member

cmil commented May 2, 2024

This issue more or less duplicates #13. To paraphrase: the XSL transformation already creates the textClass/classCode markup. It omits the keywords element because this is currently not used by the API and is kind of redundant. The remaining question is do we want to somehow map the sub genres occurring in the EarlyPrint sources to the textClasses currently recognised and supported by DraCor (which are the one defined in https://github.com/dracor-org/dracor-api/blob/0fe102e735708e4f3cfe3e736d54b23a3a1a9514/modules/config.xqm#L77).

See also dracor-org/dracor-schema#52.

@lucagiovannini7
Copy link
Member Author

lucagiovannini7 commented May 2, 2024

Thanks! This also answers a point we were discussing today with @peertrilcke: the <normalizedGenre> in the metadata table is actually generated from the Wikidata items via mapping.

@cmil
Copy link
Member

cmil commented May 2, 2024

Let's discuss remaining questions in #13.

@cmil cmil closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants