Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the snapshot::big_value_mu_ within serializer for big values #4152

Open
kostasrim opened this issue Nov 19, 2024 · 0 comments
Open

Lock the snapshot::big_value_mu_ within serializer for big values #4152

kostasrim opened this issue Nov 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kostasrim
Copy link
Contributor

Currently we lock the mutex within BucketSaveCb, OnDbChange and OnJournalEntry. A better alternative is to lock it when we actually use the serializer object (for example SaveEntry). This will guarantee that the mutex is always locked when we serialize a big value.

@kostasrim kostasrim added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant