From 9274a01fe8eb7c3d9569b8c9770c6c8ba045765c Mon Sep 17 00:00:00 2001 From: Albie Spriddell Date: Tue, 19 Dec 2023 11:22:16 +0000 Subject: [PATCH] remove todos (they're raised by analyzer) --- DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs b/DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs index 8d0ae0a..7baba03 100644 --- a/DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs +++ b/DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs @@ -224,7 +224,6 @@ private static RequestSymbolMetadata GetRequestSymbolMetadata(Compilation compil // only allow public, protected and protected internal properties if (candidate.DeclaredAccessibility is Accessibility.Private or Accessibility.Internal) { - // todo diagnostic warning continue; } @@ -239,7 +238,6 @@ private static RequestSymbolMetadata GetRequestSymbolMetadata(Compilation compil // if a method is declared, ensure it's not void if (returnType.SpecialType == SpecialType.System_Void) { - // todo return diagnostic warning continue; } @@ -254,14 +252,12 @@ private static RequestSymbolMetadata GetRequestSymbolMetadata(Compilation compil if (candidateMethod == null) { - // todo return diagnostic warning (no getter) continue; } // inherited properties that are private or internal are ignored if (depth > 0 && candidateMethod.DeclaredAccessibility is Accessibility.Private or Accessibility.Internal) { - // todo return diagnostic warning (getter not accessible) continue; }