From 3af434e0153e455abe777ffa9ebdf88d9cc20091 Mon Sep 17 00:00:00 2001 From: Loris Sauter Date: Fri, 12 Jan 2024 22:43:50 +0100 Subject: [PATCH] Added clarifying comments --- .../kotlin/dev/dres/run/InteractiveSynchronousRunManager.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/backend/src/main/kotlin/dev/dres/run/InteractiveSynchronousRunManager.kt b/backend/src/main/kotlin/dev/dres/run/InteractiveSynchronousRunManager.kt index 8fe92cf4..53949ce7 100644 --- a/backend/src/main/kotlin/dev/dres/run/InteractiveSynchronousRunManager.kt +++ b/backend/src/main/kotlin/dev/dres/run/InteractiveSynchronousRunManager.kt @@ -259,6 +259,7 @@ class InteractiveSynchronousRunManager( /* Reset the ReadyLatch. */ //this.readyLatch.reset(VIEWER_TIMEOUT_DEFAULT) + /* Since the viewer sends its ready message too early, if we reset the readyLatch here, we will override the previously sent ready and will always run into the timout */ } @@ -472,6 +473,7 @@ class InteractiveSynchronousRunManager( if (taskTemplateId == currentTemplateId) { val status = this.evaluation.currentTaskRun?.status // if (status == ApiTaskStatus.PREPARING) { + /* Since the viewer does sent the ready message too early, we cannot care whether the task is (already) preparing or not) */ this.readyLatch.register(viewerInfo) //avoid redying previously untracked viewers this.readyLatch.setReady(viewerInfo) // }