Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1328] Added DRUPAL_CONFIG_DIRECTORY variable override. #1329

Closed

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Jun 3, 2024

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added DRUPAL_CONFIG_DIRECTORY environment override for config sync directory.

Issue Link: #1328

@richardgaunt richardgaunt changed the title Add DRUPAL_CONFIG_DIRECTORY variable override. #1328 Add DRUPAL_CONFIG_DIRECTORY variable override. Jun 3, 2024
@richardgaunt richardgaunt changed the title #1328 Add DRUPAL_CONFIG_DIRECTORY variable override. [#1328] Added DRUPAL_CONFIG_DIRECTORY variable override. Jun 3, 2024
@richardgaunt richardgaunt added PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request PR: Do not review Do not review this pull request labels Jun 3, 2024
@richardgaunt
Copy link
Collaborator Author

https://github.com/drevops/scaffold/pull/1314/files
Need to implement in same way as this PR.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (efb3308) to head (4009880).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1329       +/-   ##
============================================
- Coverage    57.25%   46.64%   -10.62%     
============================================
  Files           41       41               
  Lines         3051     3051               
============================================
- Hits          1747     1423      -324     
- Misses        1304     1628      +324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk changed the title [#1328] Added DRUPAL_CONFIG_DIRECTORY variable override. [#1328] Added DRUPAL_CONFIG_DIRECTORY variable override. Jun 3, 2024
@AlexSkrypnyk
Copy link
Member

@richardgaunt
Thank you for your ideas and contribution.

We've implemented this with additional test coverage in #1330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Do not review Do not review this pull request PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants