Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pirate Ship trashing misinterpreted #5

Open
malcolmsharpe opened this issue Aug 13, 2012 · 3 comments
Open

Pirate Ship trashing misinterpreted #5

malcolmsharpe opened this issue Aug 13, 2012 · 3 comments

Comments

@malcolmsharpe
Copy link
Contributor

Pirate Ship's log message shows the attacker trashing, not the defender, which confuses the extension.

Example Pirate Ship trash log:

blueblimp - plays Pirate Ship
Conqueror Bot - reveals Silver, Estate
blueblimp - trashes Silver

The extension interprets this as blueblimp losing a Silver, when actually Conqueror Bot that loses a Silver.

The wording of Pirate Ship suggests that it's the defending player that actually performs the trash, so this log format might be a bug in Goko.

@malcolmsharpe
Copy link
Contributor Author

Thief has the same problem:

blueblimp - plays Thief
Conqueror Bot - reveals: Copper, Gold
blueblimp - trashes Gold
blueblimp - gains Gold

@drheld
Copy link
Owner

drheld commented Aug 13, 2012

These sound like a bug. I guess we can hack around it for now, but should probably file an issue about this too.

@malcolmsharpe
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants