dronecan 1140.RCInput: add flags to represent LQ and SNR link statistics #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliw42
force-pushed
the
owpr-rcinput-linkstats
branch
from
6cb09b9 to
e5fd0de
Compare
|
EDIT: I "discovered" that ArduPilot's OSD wants rssi in dBm and not rssi in 0..255, and I couldn't determine a backwards compatible method of using rssi. So added RSSI_DBM option. |
tpwrules
suggested changes
Oct 12, 2024
|
question: would it be acceptable to carry TWO data in one transmission of the quality field? the specific use case would be to carry both LQ and the active_antenna in quality. LQ is from 0..100, so the 8th bit is not used, and could be used to carry the bit required for active_antenna. |
…na, and tx power link statistics
olliw42
force-pushed
the
owpr-rcinput-linkstats
branch
from
dcdaeae to
ab11812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two flags to allow representing LQ and SNR link stats.
As suggested in ArduPilot/ardupilot#28295.
Adds a possible mapping from RSSI vlaues onto the scaled values. It is motivated by https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_RCProtocol/AP_RCProtocol_CRSF.cpp#L602-L610 (with slight adaption).
Also adds a note on the rc channels mid value to clarify the representation of the rc channels values.